liquid: import various algorithms and utils from package limes #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majewsky
requested review from
SuperSandro2000,
VoigtS and
Nuckal777
as code owners
To make these utility functions available to external LIQUID implementors, such as liquid-ceph. - `limes/internal/util/algorithms.go` -> `liquidapi/algorithms.go` without any changes - `limes/internal/util/algorithms_test.go` -> `liquidapi/algorithms_test.go` with minimal changes (type `db.ProjectServiceID` is replaced by a local type) - `limes/internal/liquids/utils.go` -> `liquidapi/utils.go` and `gophercloudext/utils.go` except for func PointerTo (which I hope to eliminate in Go 1.24)
majewsky
force-pushed
the
liquidapi-utils
branch
from
a294925 to
13f485a
Compare
VoigtS
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make these utility functions available to external LIQUID implementors, such as liquid-ceph.
limes/internal/util/algorithms.go->liquidapi/algorithms.gowithout any changeslimes/internal/util/algorithms_test.go->liquidapi/algorithms_test.gowith one small change (typedb.ProjectServiceIDis replaced by a local type)limes/internal/liquids/utils.go->liquidapi/utils.goandgophercloudext/utils.goexcept for func PointerTo (which I hope to eliminate in Go 1.24)