Allow all-ports listener (port 0), but only one per LB #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discussed in the Octavia sync all on Apr 19, while technically feasible, we agreed Benjamin will request the actual specific use-case from the LoB, to see if we actually need this feature, because of the fact that even if the listener is listening on all ports, with the listener port-translation enabled (default), the server side communication would still be using the pool-member destination port. We need to understand what the customer is trying to achieve. |
BenjaminLudwigSAP
changed the base branch from
stable/ussuri-m3
to
stable/yoga-m3
BenjaminLudwigSAP
changed the base branch from
stable/yoga-m3
to
stable/ussuri-m3
Unfortunately, ListenersController._validate_allports_listeners is not enough in the case of fully populated LBs. It can only check against listeners already existing in the DB. Therefore LoadBalancersController._validate_internal_listener_conflicts is needed as well.
BenjaminLudwigSAP
force-pushed
the
all-ports-listener
branch
from
d711a6a
to
32ebdd3
Compare
BenjaminLudwigSAP
changed the base branch from
stable/ussuri-m3
to
stable/yoga-m3
|
Cherry-picked commits basing on stable/yoga-m3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, ListenersController._validate_allports_listeners is not enough in the case of fully populated LBs. It can only check against listeners already existing in the DB. Therefore LoadBalancersController._validate_internal_listener_conflicts is needed as well.