This repository has been archived by the owner on May 29, 2020. It is now read-only.
Per target overrides #296
Merged
Per target overrides #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 18, 2015 15:02
|
Got a little overzealous there 😎 Will fix and re-submit. |
| * Check for `dest` param on either target config or global options object | ||
| */ | ||
| if (_.isUndefined(params.dest) && _.isUndefined(options.dest)) { | ||
| logger.error(chalk.yellow('Warning: Required property ' + [this.name, this.target, 'dest'].join('') |
There was a problem hiding this comment.
Colorization and “warning” should be unnecessary here because in the end it will be printed by grunt.warn.
|
Cool, thanks! |
|
@sapegin - How do we feel about this? Happy to make any improvements necessary if it's not currently satisfactory :) |
|
Great, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #295