Skip to content
This repository has been archived by the owner on May 29, 2020. It is now read-only.

execMaxBuffer option for setting child_process.exec() maxBuffer #320

Merged
merged 2 commits into from
Feb 29, 2016

Conversation

JaroslavMoravec
Copy link

#319 If engine log a lot of messages to stdout or stderr, the child process is killed. You can increase buffer size by this option.

If you run grunt --verbose, output of fontforge will by logged by logger.

This changes has been made because fontforge produces warning messages if svg format is not fully valid and buffer of stderr can exceed and you should have some way to show these warnings.

Jaroslav Moravec added 2 commits February 29, 2016 15:31
If engine log a lot of messages to stdout or stderr, the child process is killed. You can increase buffer size by this option.

If you run grunt --verbose, output of fontforge will by logged by logger.

This changes has been made because fontforge produces warning messages if svg format is not fully valid and buffer of stderr can exceed and you should have some way to show these warnings.
@JaroslavMoravec
Copy link
Author

Default value for execMaxBuffer is same as in https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback
I didn't find how to get this value from child_process object.

@sapegin
Copy link
Owner

sapegin commented Feb 29, 2016

Cool, thanks!

sapegin added a commit that referenced this pull request Feb 29, 2016
execMaxBuffer option for setting child_process.exec() maxBuffer
@sapegin sapegin merged commit f7183a6 into sapegin:master Feb 29, 2016
@JaroslavMoravec
Copy link
Author

Cool, thanks too.

@sapegin
Copy link
Owner

sapegin commented Mar 3, 2016

Out in 1.2.0, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants