brainvision tests #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's how I would have written it. But I miss understood the yield. (I think) |
|
cf69e87 should make the trick. And we get nice naming: ~/code/mne-python bvtests* 12s
(mne) ❯ pytest ./mne/io/brainvision/tests/test_brainvision.py -k foo -vs
Coverage.py warning: --include is ignored because --source is set (include-ignored)
Test session starts (platform: linux, Python 3.6.8, pytest 4.4.0, pytest-sugar 0.9.2)
cachedir: .pytest_cache
rootdir: /home/sik/code/mne-python, inifile: setup.cfg
plugins: timeout-1.3.3, sugar-0.9.2, pudb-0.7.0, mock-1.10.3, faulthandler-1.5.0, cov-2.6.1
collecting ... ('Mk1=New Segment,,1,1,0,20131113161403794232\n', list([1384359243, 794231]), '2013-11-13 16:14:03 GM')
mne/io/brainvision/tests/test_brainvision.py::test_foo[foo0] ✓ 25% ██▌ ('Mk1=STATUS,,1,1,0\n', None, 'unspecified')
mne/io/brainvision/tests/test_brainvision.py::test_foo[foo1] ✓ 50% █████ ('Mk1=New Segment,,1,1,0,\n', None, 'unspecified')
mne/io/brainvision/tests/test_brainvision.py::test_foo[foo2] ✓ 75% ███████▌ ('Mk1=New Segment,,1,1,0\n', None, 'unspecified')
mne/io/brainvision/tests/test_brainvision.py::test_foo[foo3] ✓ 100% ██████████
----------------------------------------------------------------------------------- generated xml file: /home/sik/code/mne-python/junit-results.xml -----------------------------------------------------------------------------------
====================================================================================================== slowest 20 test durations ======================================================================================================
1.59s setup mne/io/brainvision/tests/test_brainvision.py::test_foo[foo0]
(0.00 durations hidden. Use -vv to show these durations.)
Results (10.80s):
4 passed
16 deselected
~/code/mne-python bvtests* 11s
(mne) ❯ |
added 2 commits
August 2, 2019 18:43
massich
commented
Aug 2, 2019
| # ('Mk1=New Segment,,1,1,0\n', 'unspecified'), | ||
| # ('Mk1=New Segment,,1,1,0,00000000000304125000', 'unspecified'), | ||
| # ('Mk1=New Segment,,1,1,0,\nMk2=New Segment,,2,1,0,20070716122240937454\n', '2007-07-16 12:22:40 GMT'), # noqa: E501 | ||
| # ]) |
There was a problem hiding this comment.
@sappelhoff can you finish to add the missing tests?
| @pytest.fixture(scope='session') | ||
| def _mocked_meas_date_data(tmpdir_factory): | ||
| """Helper funct. preparing the files for mocked_meas_date_file fixture.""" | ||
|
|
There was a problem hiding this comment.
maybe we don't need this empty line
| vhdr_fname = _mocked_meas_date_data['vhdr_fname'] | ||
| vmrk_fname = _mocked_meas_date_data['vmrk_fname'] | ||
| eeg_fname = _mocked_meas_date_data['eeg_fname'] | ||
| lines = _mocked_meas_date_data['lines'] |
There was a problem hiding this comment.
maybe there is a nicer way to unpack the dictionary. I started doing it with a for loop but it was looking even more ugly.
There was a problem hiding this comment.
We could use an OrderedDict and use
vhdr_fname, vmrk_fname , eeg_fname, lines = _mocked_meas_date_data.values()also: we don't need eeg_fname, so I'll cut that
| vmrk_fname=vmrk_fname, | ||
| eeg_fname=eeg_fname, | ||
| expected_meas_date=request.param['meas_date'], | ||
| expected_meas_date_repr=request.param['meas_date_repr']) |
There was a problem hiding this comment.
we only need vhrd_fname. If so:
yield dict(fname=vhdr_fname,
expected_meas_date=request.param['meas_date'],
expected_meas_date_repr=request.param['meas_date_repr'])There was a problem hiding this comment.
yes, I'll change that to the reduced version 👍
sappelhoff
reviewed
Aug 2, 2019
| # ('Mk1=New Segment,,1,1,0\n', 'unspecified'), | ||
| # ('Mk1=New Segment,,1,1,0,00000000000304125000', 'unspecified'), | ||
| # ('Mk1=New Segment,,1,1,0,\nMk2=New Segment,,2,1,0,20070716122240937454\n', '2007-07-16 12:22:40 GMT'), # noqa: E501 | ||
| # ]) |
| @pytest.fixture(scope='session') | ||
| def _mocked_meas_date_data(tmpdir_factory): | ||
| """Helper funct. preparing the files for mocked_meas_date_file fixture.""" | ||
|
|
| vhdr_fname = _mocked_meas_date_data['vhdr_fname'] | ||
| vmrk_fname = _mocked_meas_date_data['vmrk_fname'] | ||
| eeg_fname = _mocked_meas_date_data['eeg_fname'] | ||
| lines = _mocked_meas_date_data['lines'] |
There was a problem hiding this comment.
We could use an OrderedDict and use
vhdr_fname, vmrk_fname , eeg_fname, lines = _mocked_meas_date_data.values()also: we don't need eeg_fname, so I'll cut that
| vmrk_fname=vmrk_fname, | ||
| eeg_fname=eeg_fname, | ||
| expected_meas_date=request.param['meas_date'], | ||
| expected_meas_date_repr=request.param['meas_date_repr']) |
There was a problem hiding this comment.
yes, I'll change that to the reduced version 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.