fix: trim slashes from dest when flatten false; add support to ../ #47
Conversation
| const destDir = | ||
| flatten || (!flatten && !dir) | ||
| ? dest | ||
| : // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | ||
| dir.replace(dir.split('/')[0]!, dest) | ||
| : destClean |
There was a problem hiding this comment.
I guess this is same with the following code.
path.resolve(dest, path.normalize(path.join(dir, '../')))Also would you add some test cases here?
There was a problem hiding this comment.
path.resolve(dest, path.normalize(path.join(dir, '../')))
The result with this code is different from the one in the PR.
The goal is to target the build.outDir defined in vite.config. Your suggestion ended up copying the files somewhere else entirely. Is the code suggested in the PR not good? It does the job.
Also would you add some test cases here?
I'm sorry, I don't know how to do that.
There was a problem hiding this comment.
The result with this code is different from the one in the PR.
Ah, my bad I was misunderstanding. Please forget that.
I'm sorry, I don't know how to do that.
I added the tests. It seems your change breaks some behaviors.
|
My fork was behind, I tried to sync it, but the comparision with the main repo was showing changes in test files, which I didn't author and were probably out-of-date. I tried to fix it, which created unwanted extra commits and when trying to clean up the git history things got really messy. I'd rather close this PR now and perhaps submit a new one starting from a fresh fork. |
This PR addresses #46
../fromdirsodestreliably replaces the first folder in the path on.split('/')[0]destDirdoesn't end up in the root folder