Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): TypeScript 5.x compatibility #253

Merged
merged 5 commits into from
Apr 2, 2023
Merged

fix(*): TypeScript 5.x compatibility #253

merged 5 commits into from
Apr 2, 2023

Conversation

favna
Copy link
Member

@favna favna commented Mar 17, 2023

In particular, add compatibility with verbatimModuleSyntax.

Other than that I removed the last remaining const enum export.

@favna
Copy link
Member Author

favna commented Mar 17, 2023

@sapphiredev pack

@sapphiredev
Copy link

sapphiredev bot commented Mar 17, 2023

Heya @favna, I've started to run the deployment workflow on this PR at 7f0651c. You can monitor the build here!

@sapphiredev
Copy link

sapphiredev bot commented Mar 17, 2023

Hey @favna, I've released this to NPM. You can install it for testing like so:

npm install @sapphire/shapeshift@pr-253

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (40b4628) 99.27% compared to head (7f0651c) 99.27%.

❗ Current head 7f0651c differs from pull request most recent head e8fceb0. Consider uploading reports for the commit e8fceb0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          58       58           
  Lines        3470     3470           
  Branches      839      839           
=======================================
  Hits         3445     3445           
  Misses         17       17           
  Partials        8        8           
Flag Coverage Δ
14 99.27% <100.00%> (ø)
16 99.27% <100.00%> (ø)
18 99.27% <100.00%> (ø)
19 99.27% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/constraints/ArrayConstraints.ts 100.00% <100.00%> (ø)
src/constraints/BigIntConstraints.ts 100.00% <100.00%> (ø)
src/constraints/DateConstraints.ts 100.00% <100.00%> (ø)
src/constraints/NumberConstraints.ts 100.00% <100.00%> (ø)
src/constraints/StringConstraints.ts 99.41% <100.00%> (ø)
src/constraints/TypedArrayLengthConstraints.ts 100.00% <100.00%> (ø)
src/constraints/util/urlValidators.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/lib/Shapes.ts 100.00% <100.00%> (ø)
src/validators/LazyValidator.ts 100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@favna favna marked this pull request as ready for review April 2, 2023 16:26
@favna favna merged commit eba2a88 into main Apr 2, 2023
@favna favna deleted the feat/typescript-v5 branch April 2, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants