Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use moduleResolution node16 #576

Closed
wants to merge 1 commit into from
Closed

refactor: use moduleResolution node16 #576

wants to merge 1 commit into from

Conversation

favna
Copy link
Member

@favna favna commented Apr 6, 2023 •
edited
Loading

TODO once CI is green:

  • Squash all into 1 commit
  • Edit the single commit to extract the ts-config changes out
  • Make a separate commit of the ts-config changes, adding a BREAKING CHANGES line
  • Make separate commits for eslint-config, eslint-plugin, prettier-config and utilities to properly denote their changes in their respective changelogs

@favna favna self-assigned this Apr 6, 2023
@favna favna requested review from kyranet and vladfrangu as code owners April 6, 2023 15:50
@favna favna force-pushed the refactor/node16-ts5 branch 3 times, most recently from de33ff2 to 3a2ef85 Compare April 6, 2023 16:03
@favna favna force-pushed the feat/typescript-v5 branch 4 times, most recently from 298bd78 to 6a2b3cb Compare April 10, 2023 13:58
@favna favna marked this pull request as draft April 10, 2023 14:05
Base automatically changed from feat/typescript-v5 to main April 10, 2023 18:18
@favna favna force-pushed the refactor/node16-ts5 branch 2 times, most recently from 4cf5515 to 2b24794 Compare April 16, 2023 21:26
@favna favna force-pushed the refactor/node16-ts5 branch from 11f1071 to bb6c260 Compare April 27, 2023 11:06
@favna favna force-pushed the refactor/node16-ts5 branch 3 times, most recently from 24eca44 to b42b75c Compare April 27, 2023 16:35
@favna favna force-pushed the refactor/node16-ts5 branch from b42b75c to f01516e Compare May 2, 2023 13:26
@favna favna mentioned this pull request Aug 24, 2023
Merged
@favna favna closed this in #637 Aug 28, 2023
@favna favna deleted the refactor/node16-ts5 branch June 3, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner

Assignees

@favna favna

Labels
needs rebase & merge packages:discord.js-utilities packages:eslint-config packages:eslint-plugin-result packages:lexure packages:prettier-config packages:result packages:ts-config packages:utilities semver:major semver:patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@favna