refactor(cutText): improve algorithm #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
favna
force-pushed
the
refactor/cut-text/improve-algorithm
branch
from
23210ee
to
0ffbc25
Compare
favna
reviewed
Oct 27, 2024
| @@ -1,4 +1,4 @@ | |||
| import { splitText } from './splitText'; | |||
| const WordSeparatorCharacter = /[\p{Separator}\p{Punctuation}\p{Control}]/u; | |||
There was a problem hiding this comment.
What is the minimum Node version for \p and u flag in Regex? sapphire utilities targets Node >= 14.0.0 through the engines field.
There was a problem hiding this comment.
There was a problem hiding this comment.
Widely available, I checked on https://caniuse.com/mdn-javascript_builtins_regexp_unicode
|
favna
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.