refactor: resolve several sonar issues #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
requested changes
Nov 2, 2024
packages/discord-utilities/src/lib/InteractionOptionResolver.ts
Outdated
Show resolved
Hide resolved
vladfrangu
reviewed
Nov 2, 2024
packages/discord.js-utilities/src/lib/PaginatedMessages/PaginatedMessage.ts
Outdated
Show resolved
Hide resolved
favna
force-pushed
the
refactor/resolve-several-sonar-issues
branch
from
c2cc109
to
0e02e2e
Compare
Mostly code smells and 2 deprecations
favna
force-pushed
the
refactor/resolve-several-sonar-issues
branch
from
a7dc877
to
18625de
Compare
kyranet
requested changes
Nov 2, 2024
kyranet
previously approved these changes
Nov 2, 2024
vladfrangu
requested changes
Nov 2, 2024
packages/discord-utilities/src/lib/InteractionOptionResolver.ts
Outdated
Show resolved
Hide resolved
packages/discord.js-utilities/src/lib/PaginatedMessages/PaginatedMessage.ts
Outdated
Show resolved
Hide resolved
vladfrangu
approved these changes
Nov 2, 2024
packages/discord.js-utilities/src/lib/PaginatedMessages/PaginatedMessage.ts
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly code smells and 2 deprecations