-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BLAS C bindings #37
base: main
Are you sure you want to change the base?
Conversation
hi! thanks for the pr. i like the idea of having a blas api, although i'm not sure if i have all of it implemented in faer so far. |
Hi, I agree that I shouldn't try to get 100% BLAS coverage in this PR. I'll do the basic abstractions and get a couple functions working with I saw you said on reddit that you're not planning to add LAPACK APIs, though I don't think a full coverage is necessary. We only need to add the ones faer performs really well in and users can benefit from it with |
4d7655b
to
5022043
Compare
@cbeuw btw, I was able to use this PR as a BLAS library in a C++ project (only sgemm/sgemv, a small subset, but a real usecase nonetheless). It uses Eigen (which enables If you need testers or anything to help this PR, I'd be happy to help! My opinion on the CBLAS vs. BLAS Fortran API is that exposing both would be valuable. Many libraries expect the BLAS fortran API (despite the implementations being written in C), for example I added the following macros to implement Note that my fork was just to quickly hack on your PR, I don't intend on interfering with your contribution |
Add BLAS API C FFI bindings so that (eventually) faer can be used as a drop-in replacement to BLAS libraries in software like NumPy