This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
runMacro executed twice does not work anymore #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @reszelaz, do you know why the test fails? If I run the sardana-test in my docker locally everything works fine. |
|
it looks like in the first run of the PR I encountered a random event/macroexecutor error not related to the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At DESY we execute runMacro() twice on the same object.
However, after the change
https://github.com/sardana-org/sardana/pull/1476/files
it does not work anymore because you cannot delete an object from the macro_status dictionary which does not exist anymore.
Therefore if it is allowed to runMacro twice it would be good to check before deleting 'name' and 'macro_line' if they exist in the dictionary.
Otherwise if running macro twice it is forbidden (I hope not) It should be thrown an exception informing users that running macro twice is forbidden.