feat: add node:16 dynamic detection from package.json. if not defined node:14 is used #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmitry-mightydevops
commented
Jun 15, 2022
•
dmitry-mightydevops
commented
- get nodejs version from the package.json engine content
- if package.json doesn't contain engine - use node:14 (as we used to)
- if package.json doesn't exist - gracefully terminates the detection and continue to other steps
dmitry-mightydevops
requested review from
DanilaKazakevich,
kseniyashaydurova,
MikhailKorol-saritasa,
owlfog,
populov,
roman-mightydevops and
SergeyDeminSaritasa
as code owners
Co-authored-by: Mikhail Korol <mikhail.korol@saritasa.com>
populov
approved these changes
Jun 17, 2022
DanilaKazakevich
approved these changes
Jun 23, 2022
kseniyashaydurova
approved these changes
Jun 28, 2022
SergeyDeminSaritasa
approved these changes
Jul 4, 2022
owlfog
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.