Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saros/I build artifact contain duplicate library jars #830

Closed
tobous opened this issue Feb 13, 2020 · 1 comment · Fixed by #835
Closed

Saros/I build artifact contain duplicate library jars #830

tobous opened this issue Feb 13, 2020 · 1 comment · Fixed by #835
Assignees
@m273d15
Labels
Area: Infrastructure Issue affecting the infrastructure to build, test and deploy Saros and its documentation Area: IntelliJ Issue affecting Saros for IntelliJ (Saros/I)

Comments

@tobous
Copy link
Member

tobous commented Feb 13, 2020

When looking at the Saros build artifacts, I noticed that the artifact for Saros/I is considerably larger than the one for Saros/E or the Saros Server (8mb vs 5mb).

This seems to stem from many libraries (like XStream, Smack, Commons libraries, our re-packaged picocontainer, etc.) being included twice. Once in the general zip and once in the contained saros.core.jar.

This isn't a huge issue as 8mb still isn't much, but it would still be nice to avoid such duplication.
@tobous tobous added the Area: IntelliJ Issue affecting Saros for IntelliJ (Saros/I) label Feb 13, 2020
@m273d15 m273d15 added the Area: Infrastructure Issue affecting the infrastructure to build, test and deploy Saros and its documentation label Feb 17, 2020
@m273d15
Copy link
Contributor

m273d15 commented Feb 17, 2020

We have to avoid the additional jars in the saros.core.jar. Therefore, we need to introduce two different core jars (Saros/E and Saros/I are currently using the same core jar).

m273d15 added a commit that referenced this issue Feb 18, 2020
@m273d15
[BUILD] Avoid redundant jars in intellij zip
794704a 
Fix #830
@m273d15 m273d15 mentioned this issue Feb 18, 2020
Merged
m273d15 added a commit that referenced this issue Feb 18, 2020
@m273d15
[BUILD] Avoid redundant jars in intellij zip (#835)
e257a06 
* [BUILD] Avoid redundant jars in intellij zip
Fix #830 

Introduce a new flavour of saros.core jar
(called plain jar) without the dependency jars .
@tobous tobous mentioned this issue Jan 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m273d15 m273d15

Labels
Area: Infrastructure Issue affecting the infrastructure to build, test and deploy Saros and its documentation Area: IntelliJ Issue affecting Saros for IntelliJ (Saros/I)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUILD] Avoid redundant jars in intellij zip saros-project/saros
2 participants
@m273d15 @tobous