[INTERNAL][CORE] Adds security check for received activities #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was possible to impersonate yourself as another session user (required a custom modification).
m273d15
reviewed
Jul 27, 2020
| @@ -359,7 +359,7 @@ public void sendActivity(List<User> recipients, final IActivity activity) { | |||
| new Runnable() { | |||
| @Override | |||
| public void run() { | |||
| sarosSession.exec(Collections.singletonList(activity)); | |||
| sarosSession.exec(user.getJID(), Collections.singletonList(activity)); | |||
There was a problem hiding this comment.
getJID is deprecated. However, I found no alternative method (as e.g. getXMPPContact/getContact).
@stefaus How would you get the Contact/JID?
There was a problem hiding this comment.
At the moment there is no proper replacement for everything where you need the contact plus the correct resource endpoint. XMPPContact can return the current best available JID, but this could change at any time.
the user.getJID() deprecation is really old, but until we have something better working this PR looks good to me
stefaus
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible to impersonate yourself as another session user
(required a custom modification).