-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUILD] Separate transitive dependencies in core #1124
Open
FKHals
wants to merge
6
commits into
saros-project:master
Choose a base branch
from
swp-saros:pr/core-dependency-container
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[BUILD] Separate transitive dependencies in core #1124
FKHals
wants to merge
6
commits into
saros-project:master
from
swp-saros:pr/core-dependency-container
Commits on Feb 22, 2021
-
[BUILD] Separate transitive dependencies in core
so that the core can act as a dependency-container without leaking it's own (non-transitive) dependencies into the classpaths of the packages importing it while still providing the transitive dependencies that are needed by those packages. This is implemented by creating the two new configurations "bundle" and "bundleApi" which replace the previously used "releaseDep". Dependencies of the "bundle"-configuration gets extend from the "implementation"-configuration (by the gradle-java-plugin) which is not transitive and therefore it's dependencies are only visible to the core package itself while the dependencies in "bundleApi" (which the corresponding "api"-config extends from) can be used by all packages that import the core. Extension in the context of configurations means that that all the dependencies in the "bundle"-config also get added to the "implementation"-config. This solution has the advantage to other solutions (e.g. creating a new OSGI package) that the complexity of the build system is not significantly increased and no versioning of any additional OSGI packages needs to be considered. This commit includes just the preparations for the following commits that actually make this happen. So at this moment the new configs just get extended from the old "releaseDep" for compatibility reasons (this will change in the following commits). The solution was proposed and kindly explained to the authors by @m273d15 following the PR saros-project#1118. Co-authored-by: FKHals <30548867+FKHals@users.noreply.github.com> Co-authored-by: paun42 <75132590+paun42@users.noreply.github.com> Co-authored-by: panphil <74254708+panphil@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 76078a0 - Browse repository at this point
Copy the full SHA 76078a0View commit details -
[BUILD] Change eclipse project to new configs
to use the "bundle" and "bundleApi" as configurations instead of "releaseDep". Co-authored-by: Eik0fresh <39055879+Eik0fresh@users.noreply.github.com> Co-authored-by: paun42 <75132590+paun42@users.noreply.github.com> Co-authored-by: panphil <74254708+panphil@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 8550564 - Browse repository at this point
Copy the full SHA 8550564View commit details -
[BUILD] Change stf project to new configs
to use the "bundle" and "bundleApi" as configurations instead of "releaseDep". Co-authored-by: Eik0fresh <39055879+Eik0fresh@users.noreply.github.com> Co-authored-by: paun42 <75132590+paun42@users.noreply.github.com> Co-authored-by: panphil <74254708+panphil@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 3b8c18e - Browse repository at this point
Copy the full SHA 3b8c18eView commit details -
[BUILD] Use bundle/bundleApi as new default configs
and remove the last remains of the previous default configuration "releaseDep". Co-authored-by: Eik0fresh <39055879+Eik0fresh@users.noreply.github.com> Co-authored-by: paun42 <75132590+paun42@users.noreply.github.com> Co-authored-by: panphil <74254708+panphil@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for d8dba44 - Browse repository at this point
Copy the full SHA d8dba44View commit details
Commits on Feb 24, 2021
-
[BUILD] Prevent the core from exporting commons-io
and instead let every project get it by itself, since it is not part of the cores public api and it further reduces the coupling between the core and these projects. We decided that this should be a separate commit from the previous ones (that also change the build-system) since it changes different files and could not be integrated coherently. Co-authored-by: Eik0fresh <39055879+Eik0fresh@users.noreply.github.com> Co-authored-by: paun42 <75132590+paun42@users.noreply.github.com> Co-authored-by: panphil <74254708+panphil@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 7afa9b1 - Browse repository at this point
Copy the full SHA 7afa9b1View commit details -
[BUILD] Prevent core from exporting commons-lang
and instead let every project get it by itself, since it is not part of the cores public api and it further reduces the coupling between the core and these projects. Co-authored-by: Eik0fresh <39055879+Eik0fresh@users.noreply.github.com> Co-authored-by: paun42 <75132590+paun42@users.noreply.github.com> Co-authored-by: panphil <74254708+panphil@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e4745e1 - Browse repository at this point
Copy the full SHA e4745e1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.