Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][E] Clean up code of Actions #629

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP][E] Clean up code of Actions #629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 21 additions & 46 deletions eclipse/src/saros/ui/actions/JumpToUserWithWriteAccessPositionAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
package saros.ui.actions;

import java.util.List;
import org.apache.log4j.Logger;
import org.eclipse.jface.action.Action;
import org.eclipse.jface.viewers.ISelection;
import org.eclipse.ui.ISelectionListener;
import org.eclipse.ui.IWorkbenchPart;
import org.eclipse.ui.PlatformUI;
import saros.SarosPluginContext;
import saros.annotations.Component;
import saros.editor.EditorManager;
Expand All @@ -17,27 +13,17 @@
import saros.ui.Messages;
import saros.ui.util.selection.SelectionUtils;
import saros.ui.util.selection.retriever.SelectionRetrieverFactory;
import saros.util.ThreadUtils;

/** Action which triggers the viewport of the local user to be changed to a local user's one. */
@Component(module = "action")
public class JumpToUserWithWriteAccessPositionAction extends Action implements Disposable {

public static final String ACTION_ID = JumpToUserWithWriteAccessPositionAction.class.getName();

private static final Logger LOG = Logger.getLogger(JumpToUserWithWriteAccessPositionAction.class);
@Inject private ISarosSessionManager sessionManager;

protected ISelectionListener selectionListener =
new ISelectionListener() {
@Override
public void selectionChanged(IWorkbenchPart part, ISelection selection) {
updateEnablement();
}
};
@Inject private EditorManager editorManager;

@Inject protected ISarosSessionManager sessionManager;

@Inject protected EditorManager editorManager;
private final ISelectionListener selectionListener = (part, selection) -> updateEnablement();

public JumpToUserWithWriteAccessPositionAction() {
super(Messages.JumpToUserWithWriteAccessPositionAction_title);
Expand All @@ -52,43 +38,32 @@ public JumpToUserWithWriteAccessPositionAction() {
updateEnablement();
}

public void updateEnablement() {
try {
List<User> participants =
SelectionRetrieverFactory.getSelectionRetriever(User.class).getSelection();
setEnabled(
sessionManager.getSession() != null
&& participants.size() == 1
&& !participants.get(0).equals(sessionManager.getSession().getLocalUser()));
} catch (NullPointerException e) {
this.setEnabled(false);
} catch (Exception e) {
if (!PlatformUI.getWorkbench().isClosing())
LOG.error("Unexpected error while updating enablement", e); // $NON-NLS-1$
}
private void updateEnablement() {
setEnabled(getTarget() != null);
}

/** @review runSafe OK */
@Override
public void run() {
ThreadUtils.runSafeSync(
LOG,
new Runnable() {
@Override
public void run() {
List<User> participants =
SelectionRetrieverFactory.getSelectionRetriever(User.class).getSelection();
if (participants.size() == 1) {
editorManager.jumpToUser(participants.get(0));
} else {
LOG.warn("More than one participant selected."); // $NON-NLS-1$
}
}
});

final User target = getTarget();

if (target == null) return;

editorManager.jumpToUser(target);
}

@Override
public void dispose() {
SelectionUtils.getSelectionService().removeSelectionListener(selectionListener);
}

private User getTarget() {
final List<User> users =
SelectionRetrieverFactory.getSelectionRetriever(User.class).getSelection();

if (users.size() == 1 && !users.get(0).isLocal() && sessionManager.getSession() != null)
return users.get(0);

return null;
}
}