Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSC] Sessions (2/3) #956

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

mschaefer88
Copy link
Contributor

@mschaefer88 mschaefer88 commented Apr 30, 2020

This pull request is the second of three to completely integrate the current state of "Saros for VS Code" into Saros.

This pull request contains all implementations regarding session management.

@mschaefer88 mschaefer88 changed the title [VSC] Accounts and contacts (2/3) [VSC] Sessions (2/3) Apr 30, 2020
The Saros implementation will be based on the Language Server Protocol
(see https://microsoft.github.io/language-server-protocol) for data exchange.
In order to enable VS Code to understand that protocol the VS Code language
client has been added. Furthermore starting of the Saros LSP Server
has been encapsulated.
Unintentionally removed parts have been
readded (lsp) and code has been improved
regarding guidelines. Overall quality has
been improved. Vscodes extension build,
run and publish workflow has been shifted
from npm based to gradle base to embed
it better into the gradle environment and
to enable easier CI builds.
In order to keep the size of the extension rather
small the building method has been changed
to webpack. This also brings the benefit
of excluding files that aren't really needed.
Introduce eslint and modify code accordingly.
Furthermore gradle has been modified in
order to seperate config and execute statements.
This commit will add the functionality of
managing accounts and contacts of
Saros. There are wizards for handling
those data and necessary UI elements
such as the contact and active account
view.
This commit will add the functionality of managing accounts and contacts of Saros.
Basic functionality like logging and config
exchange is also implemented. All classes
that will contain logic of Saros from a later
stage will be mostly empty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant