Convert pythonfinder from pydantic to vanilla dataclasses #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteius
added a commit
to pypa/pipenv
that referenced
this pull request
Jan 22, 2024
This was referenced Jan 22, 2024
matteius
added a commit
to pypa/pipenv
that referenced
this pull request
Jan 22, 2024
|
Initial pass is actually working for mac os and linux but needs some investigation on the windows side: https://github.com/pypa/pipenv/actions/runs/7606560585/job/20712546096 |
…dataclass to compare against.
…lifying assumptions.
…letely remove the posix path conversions.
matteius
changed the title
oz123
requested changes
Jan 28, 2024
oz123
approved these changes
Jan 28, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok -- This is it folks, the pythonfinder PR you've all been waiting for: removal of pydantic. I've ported the equivalent changes over to pipenv and got the tests passing there (and ported those changes back to here).
Corresponding pipenv PR that shows these changes passing: https://github.com/pypa/pipenv/actions/runs/7676466722/job/20924059607
Key highlights: