Normalize case to improve windows path finding. #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix doesn't seem correct to me. I have filed another PR #89 to address this issue, any chance if you can try it to verify? |
|
@frostming Thanks for taking a look. My fix was more of a hack that worked for me, Thanks for providing a more robust solution! I've tested and it works well! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #4330 on pypa/pipenv
Since pipenv v2018.11.26 pathfinding on windows was broken in certain scenarios (See #4330)
This resolves the issue by properly normalizing the path. This should not affect other platforms since
os.path.normcasehas no effect on other platforms.