Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parsing setup.cfg via setuptools is currently broken #216

Closed
techalchemy opened this issue Mar 27, 2020 · 0 comments · Fixed by #218
Closed

parsing setup.cfg via setuptools is currently broken #216

techalchemy opened this issue Mar 27, 2020 · 0 comments · Fixed by #218
Assignees
@techalchemy
Labels
bug Something isn't working

Comments

@techalchemy
Copy link
Member

the implementation of metadata parsing using setuptools.read_configuration in models.setup_info.setuptools_parse_setup_cfg is currently broken -- a dictionary of metadata is updated with a single element enclosed in {} (a set) which fails, and then a dictionary of extras is redefined using a list in a for loop, causing another failure.
@techalchemy techalchemy added the bug Something isn't working label Mar 27, 2020
@techalchemy techalchemy self-assigned this Mar 27, 2020
techalchemy added a commit that referenced this issue Mar 31, 2020
@techalchemy
Fix setup.cfg parsing when using setuptools
c887027 
- Fix `setuptools` based parsing of `setup.cfg` files
- Fixes #216

Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
techalchemy added a commit that referenced this issue Mar 31, 2020
@techalchemy
Fix setup.cfg parsing when using setuptools
2c7354e 
- Fix `setuptools` based parsing of `setup.cfg` files
- Fixes #216

Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
This was referenced Mar 31, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@techalchemy techalchemy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix setup.cfg parsing when using setuptools sarugaku/requirementslib
1 participant
@techalchemy