Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for parsing VCS uris with an @ sign #330

Closed
mgmarino opened this issue Jul 20, 2022 · 0 comments · Fixed by #331
Closed

Fix support for parsing VCS uris with an @ sign #330

mgmarino opened this issue Jul 20, 2022 · 0 comments · Fixed by #331

Comments

@mgmarino
Copy link
Contributor

As of #310, this fails to output the correct reference.

Example:

>>> from requirementslib import __version__
>>> __version__
'1.6.4'
>>> from requirementslib.models.requirements import Line
>>> Line("-e git+ssh://git@github.com/mycomp/our_repo.git@release/v318#egg=our_package")
<Line (editable=True, name=our_package, path=None, uri=git+ssh://git@github.com/mycomp/our_repo.git, extras=(), markers=None, vcs=git, specifier=None, pyproject=None, pyproject_requires=None, pyproject_backend=None, ireq=None)>
>>> from requirementslib import __version__
>>> __version__
'1.6.6'
>>> from requirementslib.models.requirements import Line
>>> Line("-e git+ssh://git@github.com/mycomp/our_repo.git@release/v318#egg=our_package")
<Line (editable=True, name=our_package, path=None, uri=git+ssh://git@github.com/mycomp/our_repo.git@release/v318, extras=(), markers=None, vcs=git, specifier=None, pyproject=None, pyproject_requires=None, pyproject_backend=None, ireq=None)>

Related to pypa/pipenv#5179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant