Fix an issue for projects with an at sign (@) in the path

[jervi]

It seems requirementslib is causing a crash in pipenv in some rare circumstances. If you define a package like this in a Pipfile:

myproject = {editable = true, path = "."}

and this project path contains an at sign (@), then requirementslib will parse the path wrong. The second clause in the added test case will fail without this fix.

Fixes #309

[matteius]

Thanks @jervi -- I have a fix for the test CI failing in my PR but it requires a new version of pip-shims for my other changes. I'll be able to fix that later this week and then I'll have you merge the updated main in your branch and then the tests should be runnable.

[matteius]

@jervi I have merged my changes into main -- if you can merge the latest main into your branch it should pass the next test run.

[jervi]

Thanks @matteius, I've rebased the branch now

[matteius]

@jervi it looks like the one failing test is for a VCS version which is a supported use case, so I think we have to sort out how to tell if the directory includes an @ or if the end of the path is specifying a vcs repository that is specifying the checkout version.

[jervi]

Hmm. I thought all the tests succeeded locally. I'll have another look.

[matteius]

@jervi I think that test does not run on Windows though.

[matteius]

@jervi let me know what your timeline is like; I'd like to do a release of this library in say a week or sooner if this gets finalized. My rationale for a release soon is to get the new version of pip vendored into pipenv into a release for later in April.

[jervi]

Sorry, I meant to fix this during the last weekend, but things came up. I'll try to fix the test shortly - today or tomorrow 👍

[jervi]

Long days these days 😆 I'm really sorry for the long delay. It's a bit cumbersome that the tests don't run automatically, so I can't really confirm, but I think it's working now.

[jervi]

What is a valid git ref in this context? Is it only tags or sha's? Or can it be branch names as well? This implementation will probably break if one are using a branch name for the ref and this branch contains a slash. I might need to adjust that regex a bit more...

[jervi]

Figured slashes in the ref names ought to be supported. This approach is maybe a bit naïve, but it's better than the previous attempt. All the existing tests works, and I added another test case that also works.

[nnutter]

I'm being hit by the bug (#309) this is trying to fix. Is there anything blocking this from being merged?

[matteius]

@nnutter Just that I want more reviews and confidence that its not going to break something :-) If you think it looks good, that helps me feel better about hitting the merge button. I can try to get this into a release soon.