Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue for projects with an at sign (@) in the path #310

Merged
merged 6 commits into from
Jun 25, 2022

Commits on Mar 31, 2022

  1. Fix an issue for projects with an at sign (@) in the path

    It seems `requirementslib` is causing a crash in `pipenv` in some rare circumstances. If you define a package like this in a `Pipfile`:
    ```
    myproject = {editable = true, path = "."}
    ```
    and this project path contains an at sign (`@`), then requirementslib will parse the path wrong. The second clause in the added test case will fail without this fix.
    
    Fixes sarugaku#309
    jervi committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    fc67bb9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d6c23ee View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. Detect @ character using a regex instead

    The motivation is to only care about @ that is not part of the path but rather used for git refs
    jervi committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    3c4172e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    32e7bdd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9629660 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. Make the pre-commit hook happy

    jervi committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    934b24d View commit details
    Browse the repository at this point in the history