Don't encode/decode '+' in url auth part #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostming
changed the title
frostming
commented
May 28, 2020
| @@ -132,7 +132,7 @@ def _parse_fragment(self): | |||
| extras = self.extras | |||
| for q in fragments: | |||
| key, _, val = q.partition("=") | |||
| val = unquote_plus(val.replace("+", " ")) | |||
There was a problem hiding this comment.
This replacement is not necessary as unquote_plus will handle plus characters.
There was a problem hiding this comment.
yeah, i wasn't thinking too hard at the time probably...
techalchemy
reviewed
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behaves the same as
pipURL parsing. I am not sure what the RFC says, though.'+' means a space only in a "application/x-www-form-urlencoded" context.
See original issue: pypa/pipenv#4272