Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Separate AbstractResolver and Resolver into different modules #162

Merged
merged 6 commits into from
Aug 1, 2024
Merged

fix: Separate AbstractResolver and Resolver into different modules #162

merged 6 commits into from
Aug 1, 2024

Commits on Aug 1, 2024

  1. Consolidate imports in test_resolvers.py 

    This does not need two separate `if TYPE_CHECKING` blocks, splitting
the imports across two sections.
    @pradyunsg @frostming
    pradyunsg authored and frostming committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    d131a95 View commit details
    Browse the repository at this point in the history

  2. Make resolvelib.resolvers a sub-package 

    This makes the `Resolver` object live in a diffferent module than the
`AbstractResolver`, clarifying their separation and more cleanly
accomodating additional resolver implementations.
    @pradyunsg @frostming
    pradyunsg authored and frostming committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    0d093b4 View commit details
    Browse the repository at this point in the history

  3. Export a clearly defined subset from resolvers subpackage 

    This prevents users from relying on all possible details of this
package.
    @pradyunsg @frostming
    pradyunsg authored and frostming committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    662fd4b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'typing-refactor' into pr/pradyunsg/149 

    Signed-off-by: Frost Ming <me@frostming.com>
    @frostming
    frostming committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    ecc4c96 View commit details
    Browse the repository at this point in the history

  5. fix: lint errors 

    Signed-off-by: Frost Ming <me@frostming.com>
    @frostming
    frostming committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    569084f View commit details
    Browse the repository at this point in the history

  6. fix typing 

    Signed-off-by: Frost Ming <me@frostming.com>
    @frostming
    frostming committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    ac8ed26 View commit details
    Browse the repository at this point in the history