Limit package installation to Python >= 3.7 #62
Conversation
`python_requires = >=3.4` should be updated as `python_requires = >=3.7`, else Pypi will still list it as available for Python < 3.7. Fixes sarugaku#61 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
git clean -xdf
tar zcvf ../python-shellingham_1.5.0.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-shellingham.spec ../python-shellingham_1.5.0-1.spec
mv ../python*-shellingham*1.5.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/sarugaku-shellingham-1.5.0/
rm -rf ../python*-shellingham*1.5.0*.*
See sarugaku#62
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
|
@JeppeKlitgaard @uranusjr update introduced by #50 was incomplete, may I have your kindly review for this PR? |
|
Is there anything in the code that is actually incompatible with 3.6 and lower? While unsupported, it does not mean we can’t allow older Pythons to install the version. It is still a good idea to set |
uranusjr
changed the title
As a deb/rpm packager I couldn't understand should 1.5.0 also package for Python < 3.7 (e.g. Ubuntu 18.04, CentOS 7/8, openSUSE Leap 15.3/15.4), UNTIL integrate test together with other else python packages. IMHO, if we already agree modernize Python support to >= 3.7 for on going development with #50 (after 1.4.0, before 1.5.0), then please simply yank 1.5.0 from PyPI, update the line with P.S. in case of my OBS packaging, I will keep 1.4.0 for all supported OS with Python >= 3.6, but disable 1.5.0 build for legacy OS with Python < 3.7, see https://build.opensuse.org/repositories/home:alvistack/sarugaku-shellingham-1.5.0. So I do need a clear message about your package supported Python version. |
@frostming if we suppose 1.5.0 also working with Python >= 3.6, shall we enhance f26a196 with Python 3.6 test cases, plus setting Else, could we merge this PR, yank 1.5.0 from PyPI, then release a hotfix version 1.5.1 with expected changes? We are now in a confusing status with Ubuntu 18.04 and CentOS 7/8 and openSUSE Leap 15.3/15.4 (still Python 3.6). |
git clean -xdf
tar zcvf ../python-shellingham_1.5.0.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-shellingham.spec ../python-shellingham_1.5.0-1.spec
mv ../python*-shellingham*1.5.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/sarugaku-shellingham-1.5.0/
rm -rf ../python*-shellingham*1.5.0*.*
See sarugaku#62
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
git clean -xdf
tar zcvf ../python-shellingham_1.5.0.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-shellingham.spec ../python-shellingham_1.5.0-1.spec
mv ../python*-shellingham*1.5.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/sarugaku-shellingham-1.5.0/
rm -rf ../python*-shellingham*1.5.0*.*
See sarugaku#62
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
python_requires = >=3.4should be updated aspython_requires = >=3.7, else Pypi will still list it as available for Python < 3.7.Fixes #61
Signed-off-by: Wong Hoi Sing Edison hswong3i@pantarei-design.com