Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for aarch64 on QEmu #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sindre-nistad
Copy link

I discovered that shellingham did not detect the correct shell when running in Docker on a x64 machine while emulating linux/arm64.

Through some debugging, and inspecting the running code, I saw the name variable in shellingham/posix/__init__.py:92 was qemu-aarch64.
Adding that to the regex solved the problem.

I hope you find this useful, and thanks for a good package 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant