Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vistir.misc.run() not setting environment variables #55

Closed
JacobHenner opened this issue Dec 14, 2018 · 1 comment
Closed

vistir.misc.run() not setting environment variables #55

JacobHenner opened this issue Dec 14, 2018 · 1 comment

Comments

@JacobHenner
Copy link
Contributor

vistir.misc.run() is not properly setting environment variables. PR to follow.
JacobHenner added a commit to JacobHenner/vistir that referenced this issue Dec 14, 2018
@JacobHenner
Use environment variables provided as an argument to run()
695f0f2 
Previously, they were accidentally being discarded during the encoding
step.

Resolves sarugaku#55
@JacobHenner JacobHenner mentioned this issue Dec 14, 2018
Merged
@JacobHenner
Copy link
Contributor Author

Environment variables were being discarded during the encoding step. This is fixed in the referenced PR.

@JacobHenner JacobHenner mentioned this issue Dec 14, 2018
Closed
JacobHenner added a commit to JacobHenner/vistir that referenced this issue Dec 14, 2018
@JacobHenner
Use environment variables provided as an argument to run()
9b590de 
Previously, they were accidentally being discarded during the encoding
step.

Resolves sarugaku#55
JacobHenner added a commit to JacobHenner/vistir that referenced this issue Dec 14, 2018
@JacobHenner
Use environment variables provided as an argument to run()
2dbb8c4 
Previously, they were accidentally being discarded during the encoding
step.

Resolves sarugaku#55
techalchemy added a commit that referenced this issue Dec 30, 2018
@techalchemy
Add news entry for #55
46c648d 
Signed-off-by: Dan Ryan <dan@danryan.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JacobHenner