Skip to content

Commit

Permalink
HDDS-11458. Selective checks: trigger checkstyle for properties file …
Browse files Browse the repository at this point in the history
…changes (apache#7196)
  • Loading branch information
adoroszlai authored and sarvekshayr committed Oct 7, 2024
1 parent fd301fa commit 6da8e11
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
12 changes: 12 additions & 0 deletions dev-support/ci/selective_ci_checks.bats
Original file line number Diff line number Diff line change
Expand Up @@ -429,3 +429,15 @@ load bats-assert/load.bash
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=false
}

@test "properties file in resources" {
run dev-support/ci/selective_ci_checks.sh 71b8bdd8becf72d6f7d4e7986895504b8259b3e5

assert_output -p 'basic-checks=["rat","checkstyle","native"]'
assert_output -p needs-build=false
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=false
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=false
}
1 change: 1 addition & 0 deletions dev-support/ci/selective_ci_checks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,7 @@ function check_needs_checkstyle() {
"^hadoop-hdds/dev-support/checkstyle"
"pom.xml"
"src/..../java"
"src/..../resources/.*\.properties"
)
local ignore_array=(
"^hadoop-ozone/dist"
Expand Down

0 comments on commit 6da8e11

Please sign in to comment.