Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require value for ttl when using Item as value #74

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

tfwright
Copy link
Contributor

@tfwright tfwright commented Feb 6, 2024

Resolves #73

@sasa1977 thanks for considering these changes

I may have gone a little overboard on the README example changes. Let me know if you want me to scale that back :)

When considering addressing the use of the Item struct, it seemed like this line is conveying the point so I just changed it a bit to make the intention of the example more explicit.

Also, I normally wouldn't test code like this but let me know if you'd prefer to add something.

Finally, if you think this change does make sense, I wonder whether the value should be required as well?

@sasa1977
Copy link
Owner

sasa1977 commented Feb 7, 2024

Thanks! This looks fine to me. I agree that we should make value required too. I know it's strictly speaking not related to this PR, but I'm fine with sneaking it in :-)

@tfwright
Copy link
Contributor Author

tfwright commented Feb 8, 2024

@sasa1977 snuck it in :)

@sasa1977 sasa1977 merged commit 09b98ed into sasa1977:master Feb 21, 2024
9 checks passed
@sasa1977
Copy link
Owner

Finally merged, sorry for the delay, was a bit busy. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caches not expiring
2 participants