[Feature] Membership authentication error handling #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
saseungmin
commented
Feb 27, 2021
•
saseungmin
commented
- npm install dependencies axios and notistack
- Error handling when the input value is empty during member authentication
- npm install dependencies axios and notistack - Error handling when the input value is empty during member authentication
saseungmin
commented
Feb 27, 2021
Comment on lines
+91
to
+107
| const props = { | ||
| auth: { | ||
| type: 'register', | ||
| visible: true, | ||
| }, | ||
| fields: { | ||
| register: { | ||
| userId: 'test', | ||
| password: 'test', | ||
| passwordConfirm: 'test', | ||
| }, | ||
| login: { | ||
| userId: '', | ||
| password: '', | ||
| }, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
리팩토링 필요.
중복되는 테스트 케이스 코드가 많다.
fixtures 폴더를 만들어 테스트에 필요한 데이터를 가져다가 써주자.
Comment on lines
76
to
+83
| const handleSubmit = (e) => { | ||
| e.preventDefault(); | ||
|
|
||
| if (!isCheckValidate(authFieldsState)) { | ||
| enqueueSnackbar(EMPTY_AUTH_INPUT, { | ||
| variant: 'error', | ||
| }); | ||
| } |
- install @material-ui/core
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 34 34
Lines 286 293 +7
Branches 40 41 +1
=========================================
+ Hits 286 293 +7
Continue to review full report at Codecov.
|
|
테스트 오류 수정
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.