Implement optional io.Reader in AudioRequest (#303) (#265) #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
+ Coverage 92.36% 93.05% +0.68%
==========================================
Files 19 18 -1
Lines 655 648 -7
==========================================
- Hits 605 603 -2
+ Misses 37 33 -4
+ Partials 13 12 -1
|
|
It'd be nice to include this feature in the Files Upload, Image Edit, and Image Variation endpoints as well |
|
@mdarc thank you for the PR! Would love to merge it once the test coverage issue is fixed |
Coverage issue fixed. (and np! I'm glad to contribute) |
This was referenced Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an optional
io.Readerto theAudioRequeststructure. This addition makes this structure more versatile and allows you to use a different source other than an existing file from your filesystem. It also maintaining backwards compatibility.I'd be glad to implement the same logic for the other Request types (
FileRequest,ImageEditRequest,ImageVariRequest) in preferably subsequent PR's.