remove omitempty tag from temperature fields (#333) #334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirmed the OpenAI API documentation. The default value for temperature is1
. The temperature field of the request structure was given anomitempty
tag, so a value of0
was removed from the request parameter. It would be better to remove theomitempty
tag so that0
can be used.Oops, removing the omitempty tag changes the default value in this client library.
I thought it would be better to change the temperature type to pointer(*float32). But that is BREAKING CHANGES.
Refs:
Note: For audio api only, the default value for temperature is
0
.Refs: https://platform.openai.com/docs/api-reference/audio/create