Feat Support chat completion response format and seed new fields #525
Conversation
Codecov Report
@@ Coverage Diff @@
## master #525 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 19 19
Lines 872 872
=======================================
Hits 851 851
Misses 15 15
Partials 6 6
|
|
IMO lint should be a separate PR but this LGTM -- consider also adding https://platform.openai.com/docs/api-reference/chat/create#chat-create-seed |
chat.go
Outdated
| Stream bool `json:"stream,omitempty"` | ||
| Stop []string `json:"stop,omitempty"` | ||
| PresencePenalty float32 `json:"presence_penalty,omitempty"` | ||
| ResponseFormat *ChatCompletionResponseFormat `json:"response_format,omitempty"` |
There was a problem hiding this comment.
Let's address seed:
| ResponseFormat *ChatCompletionResponseFormat `json:"response_format,omitempty"` | |
| ResponseFormat *ChatCompletionResponseFormat `json:"response_format,omitempty"` | |
| Seed *int `json:"seed,omitempty"` |
|
I agree @stillmatic |
henomis
changed the title
|
@henomis thank you for the PR! Could you please rebase on the latest master version so we could have clean CI runs here? (works for other PRs too!) |
…-completion-response-format
chat.go
Outdated
| Stream bool `json:"stream,omitempty"` | ||
| Stop []string `json:"stop,omitempty"` | ||
| PresencePenalty float32 `json:"presence_penalty,omitempty"` | ||
| ResponseFormat *ChatCompletionResponseFormat `json:"response_format,omitempty"` |
There was a problem hiding this comment.
May not the best choice to set the type as a pointer. Should we use the value type as the other field.
| Stream bool `json:"stream,omitempty"` | ||
| Stop []string `json:"stop,omitempty"` | ||
| PresencePenalty float32 `json:"presence_penalty,omitempty"` | ||
| ResponseFormat ChatCompletionResponseFormat `json:"response_format,omitempty"` |
There was a problem hiding this comment.
This is optional. So it should have been a pointer: *ChatCompletionResponseFormat. Now I get:
status code: 400, message: '' is not one of ['json_object', 'text'] - 'response_format.type'
Describe the change
This branch implements the support for chat completion response format optional field
Describe your solution
A new type has been added to support this new field.