Feat: Add assistant usage #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #649 +/- ##
=======================================
Coverage 98.44% 98.44%
=======================================
Files 24 24
Lines 1347 1347
=======================================
Hits 1326 1326
Misses 15 15
Partials 6 6 ☔ View full report in Codecov by Sentry. |
|
Thank you for the PR! |
sashabaranov
reviewed
Feb 2, 2024
run.go
Outdated
| @@ -26,6 +26,7 @@ type Run struct { | |||
| Tools []Tool `json:"tools"` | |||
| FileIDS []string `json:"file_ids"` | |||
| Metadata map[string]any `json:"metadata"` | |||
| Usage *RunUsage `json:"usage,omitempty"` | |||
There was a problem hiding this comment.
I'm not sure we need a separate RunUsage type here.
Also, let's not use a pointer here, see other Usage examples in the repo: https://github.com/search?q=repo%3Asashabaranov%2Fgo-openai%20Usage&type=code
There was a problem hiding this comment.
@shadowpigy and a minor change: please remove the pointer
sashabaranov
reviewed
Feb 8, 2024
sashabaranov
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #647