Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Completion request support seed #800

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

eiixy
Copy link
Contributor

@eiixy eiixy commented Jul 19, 2024

feat: #788

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.88%. Comparing base (774fc9d) to head (9b15daf).
Report is 27 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #800      +/-   ##
==========================================
+ Coverage   98.46%   98.88%   +0.42%     
==========================================
  Files          24       26       +2     
  Lines        1364     1343      -21     
==========================================
- Hits         1343     1328      -15     
+ Misses         15        9       -6     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@sashabaranov sashabaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eiixy Thank you for the PR! Could we please keep the order of fields?

@eiixy
Copy link
Contributor Author

eiixy commented Jul 19, 2024

感谢您的公关!我们能否请保持字段的顺序?

ok~

@eiixy Thank you for the PR! Could we please keep the order of fields?

I think it would be better to keep the field order consistent with the OpenAI documentation to compare the differences.

@sashabaranov sashabaranov merged commit 2c6889e into sashabaranov:master Aug 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants