fix MaxCompletionTokens typo #862
Merged
+31
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #862 +/- ##
==========================================
+ Coverage 98.46% 99.04% +0.58%
==========================================
Files 24 26 +2
Lines 1364 1461 +97
==========================================
+ Hits 1343 1447 +104
+ Misses 15 8 -7
Partials 6 6 ☔ View full report in Codecov by Sentry. |
|
hey @sashabaranov could you take a look at this PR 😁 |
|
Thank you, it seems like this is fixed in an earlier PR! #860 |
|
@sashabaranov that PR did fix the json tag but leaves many typos, which I also fixed. |
|
Ah, got it, thanks! |
|
@sashabaranov fixed |
sashabaranov
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently API calls to o1 models are broken due to a typo in the json tag of
ChatCompletionRequestThis PR corrects the spelling of
MaxCompletionsTokenstoMaxCompletionTokensand also fixes the json tagmax_completion_tokens.There already exists a similar PR but it doesn't fix all occurrences of the typo.