-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fish shell completion to be compatible with macOS/BSD #63
Conversation
`find` on macOS/BSD doesn't support `-printf`. See also conda/conda#7575.
I ran into a bug in the vex completions: sashahart/vex#63.
`dirname` on macOS/BSD only supports one pathname, while `basename` supports multiple.
a5940c9
to
4b11253
Compare
`vex --make` creates a new virtualenv, so there's no need to complete existing ones. rouge8/dotfiles@b7c569f
bc14f2a
to
e99f8b3
Compare
Sorry - I'm refusing this PR "without prejudice" - feel free to submit other PRs based on some of the same changes. If you want to know more, see below for details... This PR seems to be lumping together a number of different issues that I would rather address separately. The most important issue is compatibility, but you also have written a number of bug fixes, features or other customizations included here without mention outside of commit messages. As far as compatibility, you already have the best solution: use the code you have prepared as your own For other users, specifically the subset of users who are insistent about using Mac OS and fish and also vex, I think it is a reasonable stopgap to install GNU As far as offering better integration with Mac OS or BSD: Mac OS compatibility isn't the same thing as BSD compatibility, and you can't just run them together like that. Users on say FreeBSD are not automatically served by changing things to suit the corporate strategy of Apple. I'm not going to merge patches about BSD compatibility or claim BSD compatibility without actually testing on real BSD, anything less is a disservice to BSD users. Anyway, the crucial practical point here is that I can't legally test on Mac OS without buying Apple hardware (it is literally against the license for Mac OS, even if I wanted to purchase Mac OS just to do patches for vex, which I don't). So it's not practically possible for me to verify anything works or not on Mac OS. It's not that I don't care, but I legally can't do it without spending thousands of dollars of my own money, which would require me to break the law. By contrast, it is possible to do legally on some *BSD or other and I could be lured into setting up a VM to verify that prior to a merge. I have done this with Windows (which does legally allow me to do so without paying them a cent). But still, that's a few hours of my time, so I'm only going to do it if someone else puts in a comparable share of sweat equity. About the other features that aren't actually about compatibility: I'm not going to replace the whole completion in one multi-subject lump. I'm willing to merge PRs for individual changes one at a time. I'm not personally going to do the work of taking a lump of code and picking it apart and defining the test conditions for each feature. If you can isolate individual bug fixes or features, make them very clear to understand, and show that each fix/feature is working correctly on some BSD that I can legally use - then I would be happy to merge them one at a time. I'm sure that would make the fish support extra nice. All the better if someone or other would offer similar help with enhancements to support on more popular shells like However, I'm not motivated to do the majority of the grunt work on this myself, because I don't use Hope you understand. |
The maintainer wasn't interested in sashahart/vex#63 and I'm not sure I'm interested in breaking out the improvements into 5 or 6 PRs and waiting 11 months for a review of them.
The maintainer wasn't interested in sashahart/vex#63 and I'm not sure I'm interested in breaking out the improvements into 5 or 6 PRs and waiting 11 months for a review of them.
The maintainer wasn't interested in sashahart/vex#63 and I'm not sure I'm interested in breaking out the improvements into 5 or 6 PRs and waiting 11 months for a review of them.
find
on macOS/BSD doesn't support-printf
. See also conda/conda#7575.I also added some other fixes and enhancements to the fish shell completions, commit by commit.