Skip to content

🛡️ Sentinel: Fix hardcoded empty env vars for secrets #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
google-labs-jules wants to merge 1 commit into from
Closed

🛡️ Sentinel: Fix hardcoded empty env vars for secrets #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/sentinel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
## 2024-10-12 - [Hardcoded Empty String as Env Var Name]
**Vulnerability:** `std::env::var("")` used to retrieve sensitive secrets.
**Learning:** Empty strings as environment variable names always fail to retrieve values, potentially causing applications to fall back to insecure defaults or crash unpredictably. This pattern often indicates a placeholder that was missed during review.
**Prevention:** Ensure all `std::env::var` calls use explicit, documented environment variable names (e.g., `KAFKA_SASL_PASSWORD`). Use linting tools that check for empty strings in such contexts.
7 changes: 4 additions & 3 deletions thunder/kafka_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,12 @@ pub async fn start_kafka(
user: &str,
tx: tokio::sync::mpsc::Sender<i64>,
) -> Result<()> {
let sasl_password = std::env::var("")
let sasl_password = std::env::var("KAFKA_SASL_PASSWORD")
.ok()
.or(args.sasl_password.clone())?;
.or(args.sasl_password.clone())
.context("SASL password must be provided via env var KAFKA_SASL_PASSWORD or args")?;

let producer_sasl_password = std::env::var("")
let producer_sasl_password = std::env::var("KAFKA_PRODUCER_SASL_PASSWORD")
.ok()
.or(args.producer_sasl_password.clone());

Expand Down