This repository was archived by the owner on May 15, 2023. It is now read-only.
Deploy linux arm64 release to github #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
reviewed
Mar 26, 2022
Comment on lines
+141
to
+145
| - uses: arduino/setup-protoc@v1 | ||
| with: { version: "${{ env.protoc_version }}", repo-token: "${{ github.token }}" } | ||
| - uses: dart-lang/setup-dart@v1 | ||
| - run: dart pub get | ||
| - run: dart run grinder protobuf |
There was a problem hiding this comment.
Will the protobuf files generated by these tasks be visible inside the Docker container, or should we run the protobuf compiler in there instead?
There was a problem hiding this comment.
The generated file is inside workspace, so that it will be available in container. It is easier this way rather than installing protoc inside the container.
There was a problem hiding this comment.
Here is an example of using this method to run pkg-standalone-linux-arm64:
https://github.com/ntkme/dart-sass-embedded/runs/5700309782?check_suite_focus=true
nex3
approved these changes
Mar 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses docker+qemu to build native arm64 release and push to github.
We can also use qemu to build native arm release but currently blocked by dart-lang/sdk#48665 so I have leaved it commented out.