Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement color spaces #1805

Open
2 of 3 tasks
Tracked by #2831
nex3 opened this issue Sep 21, 2022 · 3 comments
Open
2 of 3 tasks
Tracked by #2831

Implement color spaces #1805

nex3 opened this issue Sep 21, 2022 · 3 comments
Labels
blocked Waiting on another issue to be fixed enhancement

Comments

@nex3
Copy link
Contributor

nex3 commented Sep 21, 2022 •
edited
Loading

  • Implementation (Language)
  • Implementation (JS API)
  • Breaking changes

See sass/sass#2831
@nex3 nex3 added enhancement blocked Waiting on another issue to be fixed labels Sep 21, 2022
@nex3 nex3 mentioned this issue Sep 21, 2022
Open
13 tasks
nex3 added a commit that referenced this issue Dec 7, 2022
@nex3
[Color 4] Add initial implementation of Color Level 4
38b0c7b 
This is still missing some planned deprecations and doubtlessly has
bugs in the new features, but it's enough to provide a baseline to
begin iterating on in smaller chunks.

See #1805
See sass/sass#2831
@nex3 nex3 mentioned this issue Dec 7, 2022
Merged
nex3 added a commit that referenced this issue Dec 9, 2022
@nex3
[Color 4] Add initial implementation of Color Level 4 (#1837)
401abdd 
This is still missing some planned deprecations and doubtlessly has
bugs in the new features, but it's enough to provide a baseline to
begin iterating on in smaller chunks.

See #1805
See sass/sass#2831
@stof
Copy link
Contributor

stof commented Apr 8, 2023

@nex3 what is the state of this implementation ? Color Level 4 is now coming to all browsers (shipped in Safari and Chrome; available behind a flag in Firefox which is enabled by default in Firefox Nightly so likely to ship in a few weeks) so it would be great to have access to them in Sass.

@nex3
Copy link
Contributor Author

nex3 commented Apr 8, 2023

@mirisuzanne and I are still hammering out the details. A draft implementation is available on the features.color-4 branch, but the spec keeps changing out from under us so it's been difficult to nail down 100% final behavior. (It's paradoxically easier for browsers to change their edge case behavior than for us, since browsers have the ability to see whether something is used in the wild.)

The other big blocker here is getting tests written/updated for every corner of the (very large) proposal. Although the implementation is likely mostly correct, I'm sure I got some corners wrong in ways we won't know until we test it.

@nex3 nex3 mentioned this issue Sep 12, 2024
Merged
@stof
Copy link
Contributor

stof commented Sep 17, 2024

@nex3 the implementation should be marked as done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Waiting on another issue to be fixed enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nex3 @stof