Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom URL loaders #195

Open
Tracked by #2535
graingert opened this issue Nov 20, 2017 · 6 comments
Open
Tracked by #2535

support custom URL loaders #195

graingert opened this issue Nov 20, 2017 · 6 comments

Comments

@graingert
Copy link

similar to #9 but for:

background-url: url("./path/to/image.png");
@graingert
Copy link
Author

graingert commented Nov 20, 2017

obviating the need for https://www.npmjs.com/package/resolve-url-loader which currently uses source maps to fix url()s that are relative to the source .scss module but not the compiled .css file.

@chriseppstein
Copy link

So, for node-sass users, I wrote eyeglass and one of it's main features is an entire solution around exposing assets for installation into an application from source locations in a npm module or application and assigning the right url to them according to application configuration.

https://github.com/sass-eyeglass/eyeglass#working-with-assets

Before Eyeglass, Compass provided this capability in ruby sass.

I think this feature would be a good addition to Sass it would help standardize the implementation of asset helper tools and provide a consistent way for build pipeline integrations to address urls and imports in a holistic way and without forcing authors to opt in to a specific solution in order to interoperate.

@nex3
Copy link
Contributor

nex3 commented Nov 21, 2017

cc @xzyfer

If we do this, we'd need to do it consistently across implementations.

@xzyfer
Copy link

xzyfer commented Nov 21, 2017 via email

@graingert
Copy link
Author

graingert commented Nov 21, 2017 via email

@nex3
Copy link
Contributor

nex3 commented Jul 6, 2018

Discussion of the design for this loader should happen at sass/sass#2535. This issue will track the eventual implementation and the Dart API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants