Add shared interfaces for various AST nodes #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1401 and #1414. Adds `Dependency`, `SassDeclaration`, and `SassReference` interfaces, which expose some getters that multiple AST nodes have in common with a single type. These also add getters for common subspans (URL, name, and namespace) to the interfaces. To allow for `FunctionExpression` to have a common interface with the other two reference nodes, its old `name` getter has been renamed to `interpolatedName`, and the new `name` getter now is either just a string, or null if the name is interpolated.
nex3
requested changes
Aug 20, 2021
nex3
approved these changes
Aug 23, 2021
| ? interpolatedName.asPlain?.replaceAll('_', '-') | ||
| : interpolatedName.asPlain; | ||
| /// If this function is a plain CSS function, use [originalName] instead. | ||
| final String name; |
There was a problem hiding this comment.
I'd make this a getter, since a single String.replaceAll() isn't very expensive.
Comment on lines
81
to
83
| var quote = skipRule.text[0]; | ||
| var end = skipRule.text.indexOf(quote, 1); | ||
| return skipRule.subspan(0, end + 1); |
There was a problem hiding this comment.
This might be worth making a Span utility as well.
Comment on lines
47
to
49
| if (namespace != null) { | ||
| startSpan = startSpan.withoutInitialIdentifier().subspan(1); | ||
| } |
There was a problem hiding this comment.
Consider adding SpanExtensions.withoutNamespace().
lib/src/parse/parser.dart
Outdated
| } | ||
| } | ||
| int escapeCharacter() => | ||
| consumeEscapedCharacter(scanner); |
lib/src/utils.dart
Outdated
| return scanner.readChar(); | ||
| } | ||
| } | ||
|
|
||
| extension SpanExtensions on FileSpan { |
There was a problem hiding this comment.
This is big enough now that it should maybe go into its own file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1401 and #1414.
Adds
Dependency,SassDeclaration, andSassReferenceinterfaces,which expose some getters that multiple AST nodes have in common with a
single type.
These also add getters for common subspans (URL, name, and namespace) to
the interfaces.
To allow for
FunctionExpressionto have a common interface with theother two reference nodes, its old
namegetter has been renamed tointerpolatedName, and the newnamegetter now is either just astring, or null if the name is interpolated.