Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split SilentComment nodes on empty lines in SCSS #1945

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Split SilentComment nodes on empty lines in SCSS #1945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/parse/scss.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ class ScssParser extends StylesheetParser {
do {
while (!scanner.isDone && !isNewline(scanner.readChar())) {}
if (scanner.isDone) break;
whitespaceWithoutComments();
spaces();
} while (scanner.scan("//"));

if (plainCss) {
Expand Down
5 changes: 3 additions & 2 deletions pkg/sass_api/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## 6.3.1
## 7.0.0

* No user-visible changes.
* Silent comments in SCSS that are separated by blank lines are now parsed as
separate `SilentComment` nodes rather than a single conjoined node.

## 6.3.0

Expand Down
4 changes: 2 additions & 2 deletions pkg/sass_api/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@ name: sass_api
# Note: Every time we add a new Sass AST node, we need to bump the *major*
# version because it's a breaking change for anyone who's implementing the
# visitor interface(s).
version: 6.3.1-dev
version: 7.0.0
description: Additional APIs for Dart Sass.
homepage: https://github.com/sass/dart-sass

environment:
sdk: ">=2.17.0 <3.0.0"

dependencies:
sass: 1.62.1-dev
sass: 1.62.1

dev_dependencies:
dartdoc: ^5.0.0
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: sass
version: 1.62.1-dev
version: 1.62.1
description: A Sass implementation in Dart.
homepage: https://github.com/sass/dart-sass

Expand Down