Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Importer] Dart Implementation #2130

Merged
merged 122 commits into from
Feb 6, 2024
Merged

Conversation

jamesnw
Copy link
Contributor

@jamesnw jamesnw commented Oct 30, 2023

@jamesnw jamesnw changed the title Feature.package importer [Package Importer] Dart Implementation Oct 30, 2023
lib/src/importer/js_node_package.dart Outdated Show resolved Hide resolved
lib/src/importer/js_node_package.dart Outdated Show resolved Hide resolved
lib/src/importer/node_package.dart Outdated Show resolved Hide resolved
lib/src/importer/node_package.dart Outdated Show resolved Hide resolved
lib/src/importer/node_package.dart Outdated Show resolved Hide resolved
lib/src/importer/node_package.dart Outdated Show resolved Hide resolved
lib/src/importer/node_package.dart Outdated Show resolved Hide resolved
lib/src/importer/node_package.dart Outdated Show resolved Hide resolved
lib/src/importer/node_package.dart Outdated Show resolved Hide resolved
lib/src/js/compile.dart Outdated Show resolved Hide resolved
@jamesnw jamesnw requested a review from nex3 January 19, 2024 15:43
lib/src/js/legacy.dart Outdated Show resolved Hide resolved
lib/src/importer/node_package.dart Outdated Show resolved Hide resolved
lib/src/importer/node_package.dart Outdated Show resolved Hide resolved
lib/src/importer/node_package.dart Outdated Show resolved Hide resolved
lib/src/importer/node_package.dart Outdated Show resolved Hide resolved
lib/src/importer/node_package.dart Outdated Show resolved Hide resolved
lib/src/importer/node_package.dart Outdated Show resolved Hide resolved
lib/src/js/compile.dart Outdated Show resolved Hide resolved
@jamesnw jamesnw requested a review from nex3 January 20, 2024 03:03
* main:
  Remove the sass dependency from package.json (sass#2162)
@ntkme
Copy link
Contributor

ntkme commented Jan 26, 2024

Our spec does not cover command line usage, but I think it would be useful to add a command line flag for dart-sass. E.g. sass --node-package-importer /entrypoint/path.

We don't necessarily need to address this within this PR. It can be an enhancement at a later time.

@jamesnw jamesnw requested a review from nex3 February 1, 2024 17:26
lib/src/importer/node_package.dart Outdated Show resolved Hide resolved
@nex3 nex3 merged commit 9ee5408 into sass:main Feb 6, 2024
29 checks passed
@nex3 nex3 deleted the feature.package-importer branch February 6, 2024 22:58
lmeysel pushed a commit to lmeysel/dart-sass that referenced this pull request Feb 20, 2024
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants