Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix link to custom importer #2315

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

eliot-akira
Copy link
Contributor

@eliot-akira eliot-akira commented Aug 20, 2024

This pull request fixes the link to the custom importer option in the section "Dart Sass in the Browser" in the README.

The original link at /interfaces/StringOptionsWithImporter#importer goes to 404 page not found. In addition, the referenced interface StringOptionsWithImporter is deprecated and links to StringOptions, where the importer option is documented.

The updated URL is: https://sass-lang.com/documentation/js-api/interfaces/stringoptions/#importer


After creating this PR, I read the contribution guide and learned that I would need to sign the Google Individual CLA. Unfortunately I'd prefer not to create a Google account in order to sign the CLA, or change my Git author email. I hereby declare this PR to be in the public domain. Maybe someone who has signed a CLA can take over and get it merged - otherwise please feel free to close it.

https://opensource.google/documentation/reference/cla

Contributors must sign in with a Google account to sign the CLA or manage their CLA agreements.

One of the most common problems is that the git author email in the commit is not an email address associated with a CLA. The solution is to change the git author email to be an address covered by the CLA. That email should also be added to their GitHub account; it doesn't need to be the primary email, but it should be on the account.

@nex3 nex3 merged commit f0a0182 into sass:main Aug 21, 2024
34 checks passed
@eliot-akira
Copy link
Contributor Author

eliot-akira commented Aug 22, 2024

Thank you. I love the Sass project, may it live long and prosper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants