Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QEMU #2382

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Update QEMU #2382

merged 1 commit into from
Oct 12, 2024

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Oct 11, 2024

So far riscv64 release has been a bit flaky after we switched to native aot build on QEMU. Attempt to upgrade QEMU to see if it will help make these more stable.

https://github.com/sass/dart-sass/actions/runs/10912255003/job/30287343660
https://github.com/sass/dart-sass/actions/runs/11283989988/job/31384720406

@ntkme
Copy link
Contributor Author

ntkme commented Oct 11, 2024

@nex3 As for yesterday's failed release, we can still try re-run failed jobs. Can you please help do that? https://github.com/sass/dart-sass/actions/runs/11283989988

@nex3
Copy link
Contributor

nex3 commented Oct 11, 2024

I've restarted the old workflow (odd that it didn't send me an email about the failure).

Can you help me understand exactly what this change is doing? Is docker/setup-qemu-action out-of-date in a way that tonistiigi/binfmt isn't?

@ntkme
Copy link
Contributor Author

ntkme commented Oct 12, 2024

https://github.com/docker/setup-qemu-action?tab=readme-ov-file#inputs

By default setup-qemu-action uses tonistiigi/binfmt:latest, which has been staled at QEMU 7.0.0 for years due to concerns over some very minor potential breaking change. By switching to tonistiigi/binfmt:master, it gives us QEMU 8.1.5 as of writing.

@nex3 nex3 merged commit 164224f into sass:main Oct 12, 2024
38 checks passed
@ntkme ntkme deleted the qemu branch October 12, 2024 00:03
@ntkme
Copy link
Contributor Author

ntkme commented Oct 12, 2024

@nex3 I just checked the re-run and saw it was already taking way longer than expected. It might be stuck again. We can try stop the current run and re-run it one more time. Or maybe retry with the next release on QEMU 8.1.5 and see if that's better.

I also found someone else hitting this issue: dart-lang/sdk#56671 (comment)

Note the linked issue is mainly about a different crash, however, in that specific linked comment the author mentioned:

I'd note that the same sequence (and more) runs inside of Docker buildx (hence using QEMU) every time we release binaries, and whilst it hangs far too frequently it doesn't crash in this manner.

So this does seems to be an issue either with QEMU or dart-sdk.

@nex3
Copy link
Contributor

nex3 commented Oct 16, 2024

I think this is causing https://github.com/sass/dart-sass/actions/runs/11375079152/job/31645316320 —unless you know of a quick fix, we may have to disable riscv64 builds for now.

@ntkme
Copy link
Contributor Author

ntkme commented Oct 16, 2024

@nex3 Can you please retry it? It looks like a docker.io server issue. Maybe docker.io rate limit or simply a server glitch.

docker: Error response from daemon: Head "https://registry-1.docker.io/v2/library/debian/manifests/unstable-slim": received unexpected HTTP status: 502 Bad Gateway.

This is failing during pulling the docker image, which is before we even start running container with QEMU.

@nex3
Copy link
Contributor

nex3 commented Oct 16, 2024

Okay, yeah, it looks like the retry is running well. 😌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants