Don't compile .css files in directories to themselves #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds support for compiling .css files in directories *at all*, which had previously only worked in --watch mode. Closes #853
Awjin
approved these changes
Oct 28, 2019
lib/src/executable/options.dart
Outdated
| if (_isEntrypoint(path)) | ||
| if (_isEntrypoint(path) && | ||
| // Don't compile a CSS file to its own location. | ||
| (source != destination || p.extension(path) != '.css')) |
There was a problem hiding this comment.
Total nit: might be clearer deMorgans'ed:
!(source == destination && p.extension(path) == '.css')
|
What is the advantage of compiling a .css file? |
|
Some people use Sass as a way of minifying their plain CSS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds support for compiling .css files in directories at
all, which had previously only worked in --watch mode.
Closes #853