Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't include leading underscores in implicit namespaces #955

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Don't include leading underscores in implicit namespaces #955

merged 1 commit into from
Feb 12, 2020

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Feb 11, 2020

@nex3 nex3 requested a review from Awjin February 11, 2020 08:40
@nex3 nex3 merged commit 0a2142d into master Feb 12, 2020
@nex3 nex3 deleted the underscore-namespace branch February 12, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Awjin Awjin Awjin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implicit module namespaces shouldn't include leading underscores
2 participants
@nex3 @Awjin